Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts: Add options support for X and Y axis #41109

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Charts: Add options support for X and Y axis #41109

merged 5 commits into from
Jan 16, 2025

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Jan 16, 2025 •
edited
Loading

Fixes #

Proposed changes:

  • Allow passing in the orientation for X and Y axis
  • Passing through all the classNames

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • (cd projects/js-packages/charts && pnpm run storybook)
  • Navigate to Charts/Types/Line Chart/Docs
  • Change options.axis.x.orientation and options.axis.y.orientation
  • Ensure the orientations change as expected
image

@kangzj kangzj self-assigned this Jan 16, 2025
@kangzj kangzj requested review from annacmc and a team January 16, 2025 02:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 16, 2025
@kangzj kangzj added [Status] Needs Team Review [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 16, 2025
@kangzj kangzj force-pushed the add/x-y-axis-orientation branch from 1cbf427 to 06093b2 Compare January 16, 2025 20:52
grzegorz-cp
grzegorz-cp approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@grzegorz-cp grzegorz-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kangzj kangzj merged commit 2fb664b into trunk Jan 16, 2025
57 checks passed
@kangzj kangzj deleted the add/x-y-axis-orientation branch January 16, 2025 21:43
kangzj added a commit that referenced this pull request Jan 17, 2025
@kangzj
Charts: Add options support for X and Y axis (#41109)
40d5f22 
* allow passing in axis options

* changelog

* passing through the class names

* add options

* move defaults to component to make them available when options is passed
kangzj added a commit that referenced this pull request Jan 17, 2025
@kangzj
Charts: Add options support for X and Y axis (#41109)
a032966 
* allow passing in axis options

* changelog

* passing through the class names

* add options

* move defaults to component to make them available when options is passed
kangzj added a commit that referenced this pull request Jan 17, 2025
@annacmc @kangzj
Chart Library: Fix pie chart + add responsive stories (#41018)
3e36cc3 
* add resizable container  to the line chart stories

* add resizable container to the pie chart stories

* adds resizable container to the Pie Semi Circle Chart Stories

* changelog

* modify the pie chart component to be properly responsive

* fix semi circle chart responsiveness

* add fixed dimension stories

* fix responsive and non-responsive stories on semi circle chart

* add fixed dimensions story for pie chart

* ensure no dimension props are being passed for responsive examples.

* Remove more fixed dimensions from responsive stories

* Refactor + rebase pie chart and pie chart stories and add back in theme selection

* remove unecessary import

* add width/height back in - just for radius calculation + clarity

* don't need display:inline block here any more

* Charts: Add options support for X and Y axis (#41109)

* allow passing in axis options

* changelog

* passing through the class names

* add options

* move defaults to component to make them available when options is passed

---------

Co-authored-by: Jasper Kang <[email protected]>
coder-karen pushed a commit that referenced this pull request Jan 24, 2025
@kangzj @coder-karen
Charts: Add options support for X and Y axis (#41109)
29b9705 
* allow passing in axis options

* changelog

* passing through the class names

* add options

* move defaults to component to make them available when options is passed
coder-karen pushed a commit that referenced this pull request Jan 24, 2025
@annacmc @kangzj @coder-karen
Chart Library: Fix pie chart + add responsive stories (#41018)
81c2e84 
* add resizable container  to the line chart stories

* add resizable container to the pie chart stories

* adds resizable container to the Pie Semi Circle Chart Stories

* changelog

* modify the pie chart component to be properly responsive

* fix semi circle chart responsiveness

* add fixed dimension stories

* fix responsive and non-responsive stories on semi circle chart

* add fixed dimensions story for pie chart

* ensure no dimension props are being passed for responsive examples.

* Remove more fixed dimensions from responsive stories

* Refactor + rebase pie chart and pie chart stories and add back in theme selection

* remove unecessary import

* add width/height back in - just for radius calculation + clarity

* don't need display:inline block here any more

* Charts: Add options support for X and Y axis (#41109)

* allow passing in axis options

* changelog

* passing through the class names

* add options

* move defaults to component to make them available when options is passed

---------

Co-authored-by: Jasper Kang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorz-cp grzegorz-cp grzegorz-cp approved these changes

@annacmc annacmc Awaiting requested review from annacmc

Assignees

@kangzj kangzj

Labels
[JS Package] Charts RNA [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangzj @grzegorz-cp