-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new site setting to hide the Action Bar #41123
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:
Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall 👍
Left some suggestions.
Worth double-checking from someone from Jetpack just in case we're missing something when introducing a new field to the Jetpack/WPCOM settings API endpoints.
projects/plugins/jetpack/json-endpoints/class.wpcom-json-api-site-settings-endpoint.php
Outdated
Show resolved
Hide resolved
@@ -499,6 +499,7 @@ function ( $newsletter_category ) { | |||
'jetpack_waf_share_debug_data' => (bool) get_option( 'jetpack_waf_share_debug_data' ), | |||
'jetpack_waf_automatic_rules_last_updated_timestamp' => (int) get_option( 'jetpack_waf_automatic_rules_last_updated_timestamp' ), | |||
'is_fully_managed_agency_site' => (bool) get_option( 'is_fully_managed_agency_site' ), | |||
'wpcom_hide_action_bar' => (bool) get_option( 'wpcom_hide_action_bar' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the protocol: I found it an odd design decision that we need to provide this option both here in the ancestor class and the v4 endpoint class.
projects/plugins/jetpack/changelog/add-wpcom_hide_action_bar-site-option
Outdated
Show resolved
Hide resolved
16d37c8
to
a240e81
Compare
Related to Automattic/wp-calypso#53830
This PR adds a new general setting (wpcom_hide_action_bar) to conditionally show the Action Bar on the front end of a site. The default value will be falsy to preserve the current behavior that Action Bar is shown.
The main issue will need 2 more PRs to be complete that I'll create and link shortly:
Other information:
Testing instructions:
You need to test this PR with the other linked PRs.