CRM: Fix email invoices not sending

[gogdzl]

Fixes https://github.com/Automattic/zero-bs-crm/issues/3523

Proposed changes:

• This PR fixes a bug introduced in 6.5.0 where invoice emails are prevented from being sent.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/zero-bs-crm/issues/3523

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• Create an invoice
• Assign invoice to contact with a valid email address
• Try sending invoice via email and see the error

This PR should fix the error.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[mikestottuk]

👋 Hi Diego

Another way to do this is in https://github.com/Automattic/jetpack/blob/trunk/projects/plugins/crm/js/ZeroBSCRM.admin.invoicebuilder.js#L2094

Grab the invoice ID like this
const invID = window.zbs_invoice.invoiceObj.id;

and use it later instead of window.invoice_id

[gogdzl]

👋 Hi Diego

Another way to do this is in https://github.com/Automattic/jetpack/blob/trunk/projects/plugins/crm/js/ZeroBSCRM.admin.invoicebuilder.js#L2094

Grab the invoice ID like this
const invID = window.zbs_invoice.invoiceObj.id;

and use it later instead of window.invoice_id

I've kept the original structure to avoid any undesired side effects. I think it's good enough for a quick fix, and then we can restructure it, right?

[mikestottuk]

I've kept the original structure to avoid any undesired side effects. I think it's good enough for a quick fix, and then we can restructure it, right?

Ok, makes sense and this tests OK. I also tested other email sends

• send a quote works
• send an invoice statement works
• send an email from the CRM contact record works

[tbradsha]

Looks good to me!