Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Fiverr Logo Maker link to options-general.php #41173

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Adds Fiverr Logo Maker link to options-general.php #41173

wants to merge 2 commits into from
+50 −0

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Jan 20, 2025 •
edited
Loading

Fixes Automattic/wp-calypso#98194

Proposed changes:

  • Adds Fiverr Logo Maker link to options-general.php

Todo:

  • Add tracks events for button clicks (js) - p1737339697597419/1737327519.265729-slack-CRWCHQGUB

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Looking for new fiverr logo maker link here:
Screenshot(50)

Test sandboxed simple site:

  • Sandbox a simple site
  • Apply this branch to the sandbox with the downloader tool
  • View wp-admin options-general.php and see the logo maker link/button

Test atomic site:

  • Using a woa dev blog
  • Enable this branch in WordPress.com Features using the Jetpack beta plugin
  • View wp-admin options-general.php and see the logo maker link/button

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/fiverr branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/fiverr

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Package] Jetpack mu wpcom WordPress.com Features label Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 20, 2025
@lsl lsl requested a review from a team January 20, 2025 00:33
@lsl lsl self-assigned this Jan 20, 2025
okmttdhr
okmttdhr approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nicely. Linking to the Slack question: p1737334123275159/1737327519.265729-slack-CRWCHQGUB

madhusudhand
madhusudhand reviewed Jan 20, 2025
View reviewed changes
projects/packages/jetpack-mu-wpcom/src/features/fiverr/fiverr.php
<circle cx="250" cy="250" r="177" fill="white"/>
<path d="M500 250C500 111.93 388.07 0 250 0C111.93 0 0 111.93 0 250C0 388.07 111.93 500 250 500C388.07 500 500 388.07 500 250ZM360.42 382.5H294.77V237.2H231.94V382.5H165.9V237.2H128.45V183.45H165.9V167.13C165.9 124.54 198.12 95.48 246.05 95.48H294.78V149.22H256.93C241.62 149.22 231.95 157.58 231.95 171.12V183.45H360.43V382.5H360.42Z" fill="#1DBF73"/>
</svg>
<span style="vertical-align: middle;">Try Fiverr Logo Maker</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span style="vertical-align: middle;">Try Fiverr Logo Maker</span>
<span style="vertical-align: middle;"><?php echo esc_html__( 'Try Fiverr Logo Maker', 'jetpack-mu-wpcom' ); ?></span>

projects/packages/jetpack-mu-wpcom/src/features/fiverr/fiverr.php
Comment on lines +26 to +27
<p><b>Make an incredible logo in minutes</b></p>
<p>Pre-designed by top talent. Just add your touch.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add translation wrapper.

projects/packages/jetpack-mu-wpcom/src/features/fiverr/fiverr.php
<td>
<p><b>Make an incredible logo in minutes</b></p>
<p>Pre-designed by top talent. Just add your touch.</p>
<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button appears too close to the other paragraphs. How about a margin-top: 16px

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhusudhand madhusudhand madhusudhand left review comments

@okmttdhr okmttdhr okmttdhr approved these changes

Assignees

@lsl lsl

Labels
[Package] Jetpack mu wpcom WordPress.com Features [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings: Add Fiver logo promo to general settings
3 participants
@lsl @madhusudhand @okmttdhr