Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phan: Fix errant extra params in function calls #41263

Merged
merged 19 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions projects/packages/boost-core/.phan/baseline.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
return [
// # Issue statistics:
// PhanAbstractStaticMethodCallInStatic : 3 occurrences
// PhanParamTooMany : 2 occurrences
// PhanTypeMismatchArgumentInternal : 2 occurrences

// Currently, file_suppressions and directory_suppressions are the only supported suppressions
'file_suppressions' => [
'src/lib/class-boost-api.php' => ['PhanParamTooMany'],
'src/lib/class-cacheable.php' => ['PhanAbstractStaticMethodCallInStatic'],
'src/lib/class-utils.php' => ['PhanTypeMismatchArgumentInternal'],
],
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Code: Remove extra params on function calls.
2 changes: 2 additions & 0 deletions projects/packages/boost-core/src/lib/class-boost-api.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ private static function get_api_client() {
* @return array|\WP_Error
*/
public static function get( $path, $query = array(), $args = null ) {
// @phan-suppress-next-line PhanParamTooMany -- By default this is WPCOM_Boost_API_Client, which accepts an extra param.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why they don't just add the extra param to the interface?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but I hesitated to change the interface in case something else unknown implements it (given the filter allows that).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, for this one I might do this for now and punt the question to the team that owns it.

return self::get_api_client()->get( $path, $query, self::merge_args( $args ) );
}

Expand All @@ -67,6 +68,7 @@ public static function get( $path, $query = array(), $args = null ) {
* @return mixed
*/
public static function post( $path, $payload = array(), $args = null ) {
// @phan-suppress-next-line PhanParamTooMany -- By default this is WPCOM_Boost_API_Client, which accepts an extra param.
return self::get_api_client()->post( $path, $payload, self::merge_args( $args ) );
}

Expand Down
12 changes: 5 additions & 7 deletions projects/packages/connection/.phan/baseline.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,12 @@
*/
return [
// # Issue statistics:
// PhanParamTooMany : 40+ occurrences
// PhanTypeMismatchArgument : 40+ occurrences
// PhanPluginDuplicateConditionalNullCoalescing : 15+ occurrences
// PhanTypeMismatchReturn : 15+ occurrences
// PhanTypeMismatchArgumentProbablyReal : 9 occurrences
// PhanTypeMismatchPropertyProbablyReal : 9 occurrences
// PhanNoopNew : 8 occurrences
// PhanTypeMismatchArgumentProbablyReal : 8 occurrences
// PhanTypeMismatchReturnProbablyReal : 8 occurrences
// PhanRedundantCondition : 6 occurrences
// PhanTypeArraySuspiciousNullable : 5 occurrences
Expand All @@ -42,7 +41,7 @@
'file_suppressions' => [
'legacy/class-jetpack-options.php' => ['PhanTypeMismatchArgumentNullable', 'PhanTypeMismatchArgumentProbablyReal'],
'legacy/class-jetpack-signature.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchArgumentInternal'],
'legacy/class-jetpack-tracks-client.php' => ['PhanNonClassMethodCall', 'PhanParamTooMany', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchArgument', 'PhanTypeMismatchPropertyProbablyReal'],
'legacy/class-jetpack-tracks-client.php' => ['PhanNonClassMethodCall', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchArgument', 'PhanTypeMismatchPropertyProbablyReal'],
'legacy/class-jetpack-xmlrpc-server.php' => ['PhanAccessMethodInternal', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanRedundantCondition', 'PhanTypeMismatchArgumentNullable', 'PhanTypeMismatchDefault', 'PhanTypeMismatchReturn'],
'src/class-error-handler.php' => ['PhanTypeMismatchReturnProbablyReal'],
'src/class-heartbeat.php' => ['PhanTypeMismatchPropertyDefault'],
Expand All @@ -51,7 +50,7 @@
'src/class-partner-coupon.php' => ['PhanPluginDuplicateConditionalNullCoalescing'],
'src/class-partner.php' => ['PhanTypeMismatchPropertyProbablyReal'],
'src/class-rest-authentication.php' => ['PhanTypeMismatchPropertyDefault', 'PhanTypeMismatchPropertyProbablyReal'],
'src/class-rest-connector.php' => ['PhanParamTooMany', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentProbablyReal', 'PhanTypeMismatchReturnProbablyReal'],
'src/class-rest-connector.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchReturnProbablyReal'],
'src/class-secrets.php' => ['PhanNonClassMethodCall', 'PhanTypeMismatchArgument'],
'src/class-server-sandbox.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchArgument'],
'src/class-tokens.php' => ['PhanImpossibleTypeComparison', 'PhanTypeMismatchArgumentInternal', 'PhanTypeMismatchReturn', 'PhanTypeMismatchReturnProbablyReal'],
Expand All @@ -61,9 +60,8 @@
'src/webhooks/class-authorize-redirect.php' => ['PhanUndeclaredClassMethod'],
'tests/php/test-class-nonce-handler.php' => ['PhanPluginDuplicateAdjacentStatement', 'PhanTypeMismatchArgument'],
'tests/php/test-rest-endpoints.php' => ['PhanNoopNew', 'PhanTypeMismatchArgumentProbablyReal', 'PhanTypeMismatchReturn', 'PhanTypeMismatchReturnProbablyReal'],
'tests/php/test_Error_Handler.php' => ['PhanParamTooMany', 'PhanTypeMismatchArgument'],
'tests/php/test_Manager_integration.php' => ['PhanParamTooMany'],
'tests/php/test_Manager_unit.php' => ['PhanDeprecatedFunction', 'PhanParamTooMany', 'PhanTypeArraySuspiciousNullable', 'PhanTypeObjectUnsetDeclaredProperty'],
'tests/php/test_Error_Handler.php' => ['PhanTypeMismatchArgument'],
'tests/php/test_Manager_unit.php' => ['PhanDeprecatedFunction', 'PhanTypeArraySuspiciousNullable', 'PhanTypeObjectUnsetDeclaredProperty'],
'tests/php/test_Rest_Authentication.php' => ['PhanTypeMismatchArgument'],
'tests/php/test_Server_Sandbox.php' => ['PhanTypeArraySuspiciousNullable'],
'tests/php/test_Signature.php' => ['PhanTypeMismatchArgumentProbablyReal'],
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Code: Remove extra params on function calls.
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public static function record_event( $event ) {
return $event;
}

$pixel = $event->build_pixel_url( $event );
$pixel = $event->build_pixel_url();

if ( ! $pixel ) {
return new WP_Error( 'invalid_pixel', 'cannot generate tracks pixel for given input', 400 );
Expand Down
2 changes: 1 addition & 1 deletion projects/packages/connection/src/class-rest-connector.php
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ public static function get_user_connection_data( $rest_response = true ) {
'id' => $current_user->ID,
'blogId' => $blog_id,
'wpcomUser' => $wpcom_user_data,
'gravatar' => get_avatar_url( $current_user->ID, 64, 'mm', '', array( 'force_display' => true ) ),
'gravatar' => get_avatar_url( $current_user->ID ),
'permissions' => array(
'connect' => current_user_can( 'jetpack_connect' ),
'connect_user' => current_user_can( 'jetpack_connect_user' ),
Expand Down
80 changes: 40 additions & 40 deletions projects/packages/connection/tests/php/test_Error_Handler.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,20 +72,20 @@ public function test_store_error() {

$this->assertCount( 1, $stored_errors );

$this->arrayHasKey( 'invalid_token', $stored_errors );
$this->assertArrayHasKey( 'invalid_token', $stored_errors );

$this->assertCount( 1, $stored_errors['invalid_token'] );

$this->arrayHasKey( '1', $stored_errors['invalid_token'] );
$this->assertArrayHasKey( '1', $stored_errors['invalid_token'] );

$this->arrayHasKey( 'nonce', $stored_errors['invalid_token']['1'] );
$this->arrayHasKey( 'error_code', $stored_errors['invalid_token']['1'] );
$this->arrayHasKey( 'user_id', $stored_errors['invalid_token']['1'] );
$this->arrayHasKey( 'error_message', $stored_errors['invalid_token']['1'] );
$this->arrayHasKey( 'error_data', $stored_errors['invalid_token']['1'] );
$this->arrayHasKey( 'timestamp', $stored_errors['invalid_token']['1'] );
$this->arrayHasKey( 'nonce', $stored_errors['invalid_token']['1'] );
$this->arrayHasKey( 'error_type', $stored_errors['invalid_token']['1'] );
$this->assertArrayHasKey( 'nonce', $stored_errors['invalid_token']['1'] );
$this->assertArrayHasKey( 'error_code', $stored_errors['invalid_token']['1'] );
$this->assertArrayHasKey( 'user_id', $stored_errors['invalid_token']['1'] );
$this->assertArrayHasKey( 'error_message', $stored_errors['invalid_token']['1'] );
$this->assertArrayHasKey( 'error_data', $stored_errors['invalid_token']['1'] );
$this->assertArrayHasKey( 'timestamp', $stored_errors['invalid_token']['1'] );
$this->assertArrayHasKey( 'nonce', $stored_errors['invalid_token']['1'] );
$this->assertArrayHasKey( 'error_type', $stored_errors['invalid_token']['1'] );
$this->assertEquals( 'xmlrpc', $stored_errors['invalid_token']['1']['error_type'] );
}

Expand All @@ -108,29 +108,29 @@ public function test_store_multiple_error_codes() {

$this->assertCount( 3, $stored_errors );

$this->arrayHasKey( 'invalid_token', $stored_errors );
$this->assertArrayHasKey( 'invalid_token', $stored_errors );

$this->assertCount( 1, $stored_errors['invalid_token'] );
$this->assertCount( 1, $stored_errors['unknown_user'] );
$this->assertCount( 1, $stored_errors['invalid_connection_owner'] );

$this->arrayHasKey( '1', $stored_errors['unknown_user'] );
$this->assertArrayHasKey( '1', $stored_errors['unknown_user'] );

$this->arrayHasKey( 'error_type', $stored_errors['invalid_token']['1'] );
$this->assertArrayHasKey( 'error_type', $stored_errors['invalid_token']['1'] );
$this->assertEquals( 'xmlrpc', $stored_errors['invalid_token']['1']['error_type'] );

$this->arrayHasKey( 'nonce', $stored_errors['unknown_user']['1'] );
$this->arrayHasKey( 'error_code', $stored_errors['unknown_user']['1'] );
$this->arrayHasKey( 'user_id', $stored_errors['unknown_user']['1'] );
$this->arrayHasKey( 'error_message', $stored_errors['unknown_user']['1'] );
$this->arrayHasKey( 'error_data', $stored_errors['unknown_user']['1'] );
$this->arrayHasKey( 'timestamp', $stored_errors['unknown_user']['1'] );
$this->arrayHasKey( 'nonce', $stored_errors['unknown_user']['1'] );
$this->arrayHasKey( 'error_type', $stored_errors['unknown_user']['1'] );
$this->assertArrayHasKey( 'nonce', $stored_errors['unknown_user']['1'] );
$this->assertArrayHasKey( 'error_code', $stored_errors['unknown_user']['1'] );
$this->assertArrayHasKey( 'user_id', $stored_errors['unknown_user']['1'] );
$this->assertArrayHasKey( 'error_message', $stored_errors['unknown_user']['1'] );
$this->assertArrayHasKey( 'error_data', $stored_errors['unknown_user']['1'] );
$this->assertArrayHasKey( 'timestamp', $stored_errors['unknown_user']['1'] );
$this->assertArrayHasKey( 'nonce', $stored_errors['unknown_user']['1'] );
$this->assertArrayHasKey( 'error_type', $stored_errors['unknown_user']['1'] );
$this->assertEquals( 'rest', $stored_errors['unknown_user']['1']['error_type'] );

$this->arrayHasKey( 'invalid', $stored_errors['invalid_connection_owner'] );
$this->arrayHasKey( 'error_type', $stored_errors['invalid_connection_owner']['invalid'] );
$this->assertArrayHasKey( 'invalid', $stored_errors['invalid_connection_owner'] );
$this->assertArrayHasKey( 'error_type', $stored_errors['invalid_connection_owner']['invalid'] );
$this->assertEquals( 'connection', $stored_errors['invalid_connection_owner']['invalid']['error_type'] );
}

Expand All @@ -153,21 +153,21 @@ public function test_store_multiple_error_codes_multiple_users() {

$this->assertCount( 2, $stored_errors );

$this->arrayHasKey( 'invalid_token', $stored_errors );
$this->assertArrayHasKey( 'invalid_token', $stored_errors );

$this->assertCount( 1, $stored_errors['invalid_token'] );
$this->assertCount( 2, $stored_errors['unknown_user'] );

$this->arrayHasKey( '2', $stored_errors['unknown_user'] );
$this->assertArrayHasKey( '2', $stored_errors['unknown_user'] );

$this->arrayHasKey( 'nonce', $stored_errors['unknown_user']['2'] );
$this->arrayHasKey( 'error_code', $stored_errors['unknown_user']['2'] );
$this->arrayHasKey( 'user_id', $stored_errors['unknown_user']['2'] );
$this->arrayHasKey( 'error_message', $stored_errors['unknown_user']['2'] );
$this->arrayHasKey( 'error_data', $stored_errors['unknown_user']['2'] );
$this->arrayHasKey( 'timestamp', $stored_errors['unknown_user']['2'] );
$this->arrayHasKey( 'nonce', $stored_errors['unknown_user']['2'] );
$this->arrayHasKey( 'error_type', $stored_errors['unknown_user']['2'] );
$this->assertArrayHasKey( 'nonce', $stored_errors['unknown_user']['2'] );
$this->assertArrayHasKey( 'error_code', $stored_errors['unknown_user']['2'] );
$this->assertArrayHasKey( 'user_id', $stored_errors['unknown_user']['2'] );
$this->assertArrayHasKey( 'error_message', $stored_errors['unknown_user']['2'] );
$this->assertArrayHasKey( 'error_data', $stored_errors['unknown_user']['2'] );
$this->assertArrayHasKey( 'timestamp', $stored_errors['unknown_user']['2'] );
$this->assertArrayHasKey( 'nonce', $stored_errors['unknown_user']['2'] );
$this->assertArrayHasKey( 'error_type', $stored_errors['unknown_user']['2'] );
}

/**
Expand Down Expand Up @@ -363,18 +363,18 @@ public function test_check_api_response_for_errors() {
$verified_errors = $this->error_handler->get_verified_errors();

$this->assertCount( 1, $stored_errors );
$this->arrayHasKey( 'unknown_token', $stored_errors );
$this->assertArrayHasKey( 'unknown_token', $stored_errors );
$this->assertCount( 1, $stored_errors['unknown_token'] );
$this->arrayHasKey( '1', $stored_errors['unknown_token'] );
$this->arrayHasKey( 'error_code', $stored_errors['unknown_token']['0'] );
$this->arrayHasKey( 'error_type', $stored_errors['unknown_token']['0'] );
$this->assertArrayHasKey( 0, $stored_errors['unknown_token'] );
$this->assertArrayHasKey( 'error_code', $stored_errors['unknown_token']['0'] );
$this->assertArrayHasKey( 'error_type', $stored_errors['unknown_token']['0'] );
$this->assertEquals( 'rest', $stored_errors['unknown_token']['0']['error_type'] );

$this->assertCount( 1, $verified_errors );
$this->arrayHasKey( 'unknown_token', $verified_errors );
$this->assertArrayHasKey( 'unknown_token', $verified_errors );
$this->assertCount( 1, $verified_errors['unknown_token'] );
$this->arrayHasKey( '1', $verified_errors['unknown_token'] );
$this->arrayHasKey( 'error_code', $verified_errors['unknown_token']['0'] );
$this->assertArrayHasKey( 0, $verified_errors['unknown_token'] );
$this->assertArrayHasKey( 'error_code', $verified_errors['unknown_token']['0'] );
anomiex marked this conversation as resolved.
Show resolved Hide resolved
$this->assertEquals( 'rest', $verified_errors['unknown_token']['0']['error_type'] );
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -633,8 +633,7 @@ public function test_disconnect_user( $remote_response, $expected_user_token_cou
$this,
$callback,
),
10,
3
10
);

$this->assertCount( $expected_user_token_count, $this->manager->get_connected_users() );
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public function test_api_url_defaults() {
$this->manager->api_url( 'another_thing/' )
);

remove_filter( 'jetpack_constant_default_value', array( $this, 'filter_api_constant' ), 10, 2 );
remove_filter( 'jetpack_constant_default_value', array( $this, 'filter_api_constant' ), 10 );
}

/**
Expand Down
5 changes: 2 additions & 3 deletions projects/packages/forms/.phan/baseline.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// # Issue statistics:
// PhanTypeMismatchArgument : 20+ occurrences
// PhanPluginDuplicateConditionalNullCoalescing : 10+ occurrences
// PhanTypeMismatchReturnProbablyReal : 9 occurrences
// PhanTypeMismatchReturnProbablyReal : 10+ occurrences
// PhanTypeMismatchArgumentInternal : 6 occurrences
// PhanTypeMismatchArgumentProbablyReal : 6 occurrences
// PhanRedundantCondition : 4 occurrences
Expand All @@ -20,7 +20,6 @@
// PhanTypeConversionFromArray : 2 occurrences
// PhanTypeMismatchArgumentNullableInternal : 2 occurrences
// PhanTypeMismatchReturn : 2 occurrences
// PhanParamTooMany : 1 occurrence
// PhanPluginDuplicateAdjacentStatement : 1 occurrence
// PhanPluginMixedKeyNoKey : 1 occurrence
// PhanPossiblyNullTypeMismatchProperty : 1 occurrence
Expand All @@ -33,7 +32,7 @@
'file_suppressions' => [
'src/class-wpcom-rest-api-v2-endpoint-forms.php' => ['PhanTypePossiblyInvalidDimOffset'],
'src/contact-form/class-admin.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanRedundantCondition', 'PhanTypeArraySuspiciousNullable', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentInternal', 'PhanTypeMismatchArgumentProbablyReal', 'PhanTypeMismatchReturn'],
'src/contact-form/class-contact-form-field.php' => ['PhanParamTooMany', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanPossiblyNullTypeMismatchProperty', 'PhanTypeConversionFromArray', 'PhanTypeMismatchArgument', 'PhanTypeMismatchReturnProbablyReal', 'PhanUndeclaredProperty'],
'src/contact-form/class-contact-form-field.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanPossiblyNullTypeMismatchProperty', 'PhanTypeConversionFromArray', 'PhanTypeMismatchArgument', 'PhanTypeMismatchReturnProbablyReal', 'PhanUndeclaredProperty'],
'src/contact-form/class-contact-form-plugin.php' => ['PhanPluginDuplicateAdjacentStatement', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanPluginRedundantAssignment', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentInternal', 'PhanTypeMismatchArgumentProbablyReal', 'PhanTypeMismatchReturnProbablyReal'],
'src/contact-form/class-contact-form-shortcode.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchReturnProbablyReal'],
'src/contact-form/class-contact-form.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanPluginRedundantAssignment', 'PhanRedundantCondition', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentNullableInternal', 'PhanTypeMismatchReturnNullable', 'PhanTypeMismatchReturnProbablyReal'],
Expand Down
4 changes: 4 additions & 0 deletions projects/packages/forms/changelog/fix-phan-PhanParamTooMany
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Code: Remove extra params on function calls.
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,7 @@ public function render_field( $type, $id, $label, $value, $class, $placeholder,
$field .= $this->render_textarea_field( $id, $label, $value, $field_class, $required, $required_field_text, $field_placeholder );
break;
case 'radio':
$field .= $this->render_radio_field( $id, $label, $value, $field_class, $required, $required_field_text, $field_placeholder );
$field .= $this->render_radio_field( $id, $label, $value, $field_class, $required, $required_field_text );
break;
case 'checkbox':
$field .= $this->render_checkbox_field( $id, $label, $value, $field_class, $required, $required_field_text );
Expand Down
7 changes: 3 additions & 4 deletions projects/packages/image-cdn/.phan/baseline.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@
// # Issue statistics:
// PhanTypePossiblyInvalidDimOffset : 10+ occurrences
// PhanPluginSimplifyExpressionBool : 6 occurrences
// PhanParamTooMany : 5 occurrences
// PhanPluginDuplicateConditionalNullCoalescing : 4 occurrences
// PhanPossiblyUndeclaredVariable : 3 occurrences
// PhanPossiblyUndeclaredVariable : 2 occurrences
// PhanTypeMismatchArgumentProbablyReal : 2 occurrences
// PhanTypeMismatchPropertyProbablyReal : 2 occurrences
// PhanTypeMismatchReturn : 2 occurrences
Expand All @@ -32,8 +31,8 @@
'src/class-image-cdn-core.php' => ['PhanTypeMismatchReturn'],
'src/class-image-cdn-image-sizes.php' => ['PhanPluginSimplifyExpressionBool'],
'src/class-image-cdn.php' => ['PhanNonClassMethodCall', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanPluginSimplifyExpressionBool', 'PhanPossiblyUndeclaredVariable', 'PhanTypeArraySuspicious', 'PhanTypeMismatchArgumentInternal', 'PhanTypeMismatchPropertyProbablyReal', 'PhanTypeMismatchReturn', 'PhanTypeMismatchReturnProbablyReal', 'PhanTypePossiblyInvalidDimOffset'],
'src/compatibility/photon.php' => ['PhanParamTooMany', 'PhanTypeMismatchArgumentNullableInternal'],
'tests/php/test_class.image_cdn.php' => ['PhanParamTooMany', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanPossiblyUndeclaredVariable', 'PhanTypeMismatchArgumentNullable', 'PhanTypeMismatchPropertyProbablyReal', 'PhanUndeclaredMethod', 'PhanUndeclaredStaticMethod'],
'src/compatibility/photon.php' => ['PhanTypeMismatchArgumentNullableInternal'],
'tests/php/test_class.image_cdn.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanPossiblyUndeclaredVariable', 'PhanTypeMismatchArgumentNullable', 'PhanTypeMismatchPropertyProbablyReal', 'PhanUndeclaredMethod', 'PhanUndeclaredStaticMethod'],
'tests/php/test_class.image_cdn_core.php' => ['PhanTypeMismatchArgumentProbablyReal', 'PhanTypeObjectUnsetDeclaredProperty'],
],
// 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Code: Remove extra params on function calls.
Loading
Loading