Convert watchStuckJobs implementation to use SCAN instead of KEYS #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the implementation of the watchStubJobs LUA script to use a paginated SCAN of the keyspace, rather than the current KEYS approach. This has a significant impact in large or shared redis deployments where the keyspace can be unbounded in size. KEYS will block all execution as it runs, which can take several seconds or longer whereas the SCAN approach permits other operations to be run in between each page of results.
|
👍 when could this be reviewd or merged? |
|
This is a pretty gnarly issue. Any chance this PR could get some traction? |
|
Last commit to master in January 2018? Don't hold your breath. @snypelife |
|
womp womp 👎 |
|
bump |
|
We had to cherry pick this code with modification to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the implementation of the watchStuckJobs LUA script to use
a paginated SCAN of the keyspace, rather than the current KEYS
approach.
This has a significant impact in large or shared redis deployments
where the keyspace can be unbounded in size. KEYS will block
all execution as it runs, which can take several seconds or longer
whereas the SCAN approach permits other operations to be run in
between each page of results.