optimize fillStyle to be 10% faster

this is possibly a hot path, and avoiding the C++ string helps a little bit
Automattic · Jun 24, 2023 · 83d8af0 · 83d8af0
1 parent 42ea2ff
commit 83d8af0
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/CanvasRenderingContext2d.cc b/src/CanvasRenderingContext2d.cc
@@ -2097,8 +2097,11 @@ Context2d::_setFillColor(Napi::Value arg) {
   short ok;
 
   if (stringValue.IsJust()) {
-    std::string str = stringValue.Unwrap().Utf8Value();
-    uint32_t rgba = rgba_from_string(str.c_str(), &ok);
+    Napi::String str = stringValue.Unwrap();
+    char buf[128] = {0};
+    napi_status status = napi_get_value_string_utf8(env, str, buf, sizeof(buf) - 1, nullptr);
+    if (status != napi_ok) return;
+    uint32_t rgba = rgba_from_string(buf, &ok);
     if (!ok) return;
     state->fillPattern = state->fillGradient = NULL;
     state->fill = rgba_create(rgba);