Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Test on the latest macOS X64 and ARM64 #2403

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 16, 2024

On GitHub Actions macOS-13 is X64 and macOS-14 is ARM64.

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

  Test:
    name: Test on Node.js
    strategy:
      fail-fast: false
      matrix:
        node: [18, 20, 22]
        os: [macos-13, macos-latest, ubuntu-latest, windows-2019]
    runs-on: ${{ matrix.os }}

Thanks for contributing!

  • Have you updated CHANGELOG.md?

@cclauss cclauss changed the title GitHub Actions: Trest on the latest macOS X64 and ARM64 GitHub Actions: Test on the latest macOS X64 and ARM64 Jul 16, 2024
@pranav1344
Copy link
Contributor

Hi, thanks for asking. It appears that you haven't updated the changelog.

@cclauss
Copy link
Contributor Author

cclauss commented Jul 23, 2024

Done.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 23, 2024

@pranav1344 Your review, please.

@micheledisalvatore-newday

up, this may solve the issue with the installation on M1 devices

@cclauss
Copy link
Contributor Author

cclauss commented Oct 31, 2024

This might not solve the issue but it might make it clearer which would help us focus on solutions.

@pranav1344 The testing modernizations in https://github.com/Automattic/node-canvas/pulls/cclauss would be useful to put into place.

@cclauss
Copy link
Contributor Author

cclauss commented Dec 4, 2024

@zbjornson Your review, please.

1 similar comment
@cclauss
Copy link
Contributor Author

cclauss commented Dec 4, 2024

@zbjornson Your review, please.

@cclauss
Copy link
Contributor Author

cclauss commented Dec 6, 2024

@cclauss cclauss closed this Dec 6, 2024
@cclauss cclauss deleted the patch-2 branch December 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants