Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some small changes to the design of the settings page, mainly in the header:
Dropdown
with theDropdownMenu
component for improved a11y. Before, it wasn't possible to tab/use arrow keys to navigate within the popover as expected. Focus available on submenu now:Modal
with theConfirmDialog
componentThere is also a back button in the header on the edit/add source pages. As a result, there are a few visual changes and a new form component added. The form will be handled in a follow-up, but it was added here so the header didn't look odd in the meantime:
After with form component:
Testing Instructions