Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI updates #203

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Settings UI updates #203

wants to merge 5 commits into from

Conversation

brookewp
Copy link
Contributor

Description

Some small changes to the design of the settings page, mainly in the header:

Screenshot 2024-11-18 at 2 33 12 PM
  • replaced the Dropdown with the DropdownMenu component for improved a11y. Before, it wasn't possible to tab/use arrow keys to navigate within the popover as expected. Focus available on submenu now:
Screenshot 2024-11-18 at 2 33 19 PM
  • replaced the deletion confirmation Modal with the ConfirmDialog component
Screenshot 2024-11-18 at 2 39 29 PM

There is also a back button in the header on the edit/add source pages. As a result, there are a few visual changes and a new form component added. The form will be handled in a follow-up, but it was added here so the header didn't look odd in the meantime:
Screenshot 2024-11-18 at 1 36 04 PM
After with form component:
Screenshot 2024-11-18 at 2 34 26 PM

Testing Instructions

  • On the settings page, tab to the 'Add' menu button and use tab/arrow keys to navigate and select subitems
  • Click on the delete icon to access confirmation dialog. Click 'cancel' and then open it again and click 'Confirm' to verify the behaviour is the same as before
  • Edit/add source pages should behave the same as before, and have a back button in the header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant