Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocks checkout local pickup #773

Closed
wants to merge 1 commit into from
Closed

Conversation

alefesouza
Copy link
Member

Fixes #399

Description

Alongside woocommerce/woocommerce#54946 this PR fixes #399 issue by disabling the "supports local pickup" flag on the blocks checkout page shipping rates when there's a subscription on the cart.

This still allows the local pickup methods to be selected but changes the blocks checkout page to show all shipping methods on a single page.

Before After
Screenshot 2025-01-28 at 7 30 26 PM Screenshot 2025-01-28 at 7 59 53 PM
Screenshot 2025-01-28 at 7 28 53 PM

How to test this PR

pnpm install
cd plugins/woocommerce
pnpm watch:build

Product impact

  • Added changelog entry (or does not apply)
  • Will this PR affect WooCommerce Subscriptions? yes/no/tbc, add issue ref
  • Will this PR affect WooCommerce Payments? yes/no/tbc, add issue ref
  • Added deprecated functions, hooks or classes to the spreadsheet

Sorry, something went wrong.

@alefesouza
Copy link
Member Author

Closing to be discussed on the RFC pgizk6-7o-p2

@alefesouza alefesouza closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shipping Method Selection Conflict with Local Pickup Block
1 participant