Remove "Edit site" from the action bar

[richtabor]

An alternative to https://github.com/Automattic/dotcom-feedback/issues/302; let's just remove the "Site Editor" link from here.

The Site Editor should be treated more as an advanced toolset—not an omnipresent link in this "action bar".

Visual

[ramonjd]

Running patch here: D162881-code

[richtabor]

@ramonjd do you have an update on this? Thanks!

[ramonjd]

Thanks for the ping @richtabor

Latest is that the floating bar may be removed completely after #96022

See the comments from p58i-ioo-p2#comment-65033

cc @simison for confirmation

Either way if someone from @Automattic/dotcom-design has time to confirm whether D162881-code is still value we can pursue it in the meantime.

[github-actions]

Support References

This comment is automatically generated. Please do not edit it.

• p58i-ioo-p2#comment-65033

[richtabor]

Here's another example how rough this experience is, when you see an "Edit site" button, but you end up here:

CleanShot.2024-11-15.at.12.17.29.mp4

[ramonjd]

when you see an "Edit site" button, but you end up here

The first iteration of D162881-code (id 532692) fixed this. I think a non-controversial and easy win while we wait for a decision to remove this bar would be to fix this and just deploy. At least it would work.

[matt-west]

Sounds like a sensible approach @ramonjd 👍

[ramonjd]

I think a non-controversial and easy win while we wait for a decision to remove this bar would be to fix this and just deploy. At least it would work.

I've reverted D162881-code to do this. If anyone has time to test, I'd appreciate it. Then we can move from there.

[jeryj]

@ramonjd's approach is to fix the link to go to the specific template editor instead of the templates page. Is this a fine approach for now, or should we remove the entire "Edit Site" link? cc @richtabor

[ramonjd]

@jeryj I've got a PR ready to remove it for now.

169373-ghe-Automattic/wpcom

It's been approved so I'll commit it today or very soon.

We're also working through this list: #98042

There's a redesign proposal over in #94079 (comment)

[ramonjd]

Done via 169373-ghe-Automattic/wpcom