Improvements to floating action toolbar

[annezazu]

What follows are some tasks to improve the action bar experience. While there's broader discussion around keeping this action bar in the long run, there are also plenty of tasks to improve it in the short term. I created this from current known issues. cc @jordesign @inaikem for any additional items you can add from users or your own walkthroughs here. @davemart-in as I know you have lots of thoughts and experience here!

Now

• Ensure "Edit Site" option is consistent in both places (top toolbar and floating toolbar) #94079
• Feature Request: Hide subscriber count in Action Bar #95292
• Remove "Edit site" from the action bar #95363
• Bug: Manage subscription link in Action bar is incorrect #86454
  • WIP 170181-ghe-Automattic/wpcom
• Action bar: Change the text to "Unfollow" when a user follows a site/blog #70232
• Subscriptions: 3rd party cookie problem Action Bar #55470
• Action Bar: Line-height on each explanation under switches needs improvement #56578
  • 169935-ghe-Automattic/wpcom
• Upgrade "copy shortlink".
  • WIP 169986-ghe-Automattic/wpcom
• Fix RTL stylesheet loading:
  • WIP 169999-ghe-Automattic/wpcom
• Fix/add focus styles, in particular for keyboard navigation
• Potentially address click handler for copied_shortlink. See 169986-ghe-Automattic/wpcom#issuecomment-1041319

Next

Adding this as "next" as it's a bit of a larger task but folks are welcome to dive in here.

• Allow for users to turn off the Action Bar #53830
• Action Bar: Not available on Atomic Sites #36795

Needs design or design thinking

• Validate the action bar #96202
• Multiple "Edit" links when viewing the site as an admin #94358

[ramonjd]

Also sharing @davemart-in's redesign suggestions from #96202 (comment)

A) Cull links that no longer make sense.
B) Make the action bar optional - so anyone could turn it off if they want (but still defaulting it to be on)
C) Redesign the action bar to align more with Gutenberg. Here were a few designs I shared:

[youknowriad]

I was reviewing a PR from @ntsekouras to add a setting to show/hide the action bar and noticed that there's a lot of contradictions in some of the issues. For me it doesn't really make sense to add a setting to show/hide the action bar right now because the action bar's future is unclear. So I would like to get clarification to some of these questions:

• Do we want to remove the bar or keep it
• Do we want to make the bar available for all sites (atomic), in which case the code need to move to wpcom-mu-plugin
• Do we want to redesign it...
• Why do we want it to be hideable, for me such a setting is just a confusing setting for users and I'd prefer if we're opinionated.

[ramonjd]

Do we want to remove the bar or keep it

I think "keep it".

@davemart-in answered that over here:

#94079 (comment)

Do we want to make the bar available for all sites (atomic), in which case the code need to move to wpcom-mu-plugin

It's always been simple sites right? I see there has been one request to add it to Atomic: #36795

If the answer is "yes" maybe after redesign, and then allow it to be turned off in settings. Just a thought.

Do we want to redesign it

Yes. #94079 (comment)

Why do we want it to be hideable, for me such a setting is just a confusing setting for users and I'd prefer if we're opinionated.

I only have my lowly opinion. I don't think the collapse/hide functionality is valuable. It persists whichever form it takes (collapsed/not collapsed), so I agree with you.

If it's going to be redesigned anyway, it's a good chance to ditch that.

@Automattic/zenith has a few PRs to improve the current floating toolbar. Happy to coordinate on the redesign too.

[davemart-in]

Why do we want it to be hideable, for me such a setting is just a confusing setting for users and I'd prefer if we're opinionated.

It's worth noting that there are two separate contexts here:

1. The collapse/expand functionality that already exists. I agree that this is probably not necessary and in the redesign I'd propose getting rid of it.

2. Adding an option to General -> Settings to hide the action bar completely. This has been requested enough that I'm not against it. I think fore certain site, having the option to hide it is perfectly reasonable.

[ramonjd]

I've put a little sugar on the copy short link feature here: 169986-ghe-Automattic/wpcom