Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Update user profiles directory from user-stream to user-profile #98343

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

mehmoodak
Copy link
Member

Proposed Changes

  • Rename reader/user-stream to reader/user-profile

Why are these changes being made?

For consistency. Currently we are using two names user-stream and user-profile so this PR is making things conistent.

Testing Instructions

  • Navigate to any user profile (example)
  • Make sure everything is looking and working as expected.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mehmoodak mehmoodak self-assigned this Jan 14, 2025
@mehmoodak mehmoodak force-pushed the reader/update-user-profile-dir-name branch from 43c057b to 0d30829 Compare January 14, 2025 13:58
@matticbot
Copy link
Contributor

matticbot commented Jan 14, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~4 bytes added 📈 [gzipped])

name                                    parsed_size             gzip_size
async-load-calypso-reader-user-profile     +12208 B      (new)    +3430 B      (new)
async-load-calypso-reader-user-stream      -12200 B  (deleted)    -3426 B  (deleted)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mehmoodak mehmoodak marked this pull request as ready for review January 14, 2025 16:01
@mehmoodak mehmoodak requested a review from a team as a code owner January 14, 2025 16:01
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 16, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug reader/update-user-profile-dir-name on your sandbox.

Copy link
Contributor

@artemiomorales artemiomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@artemiomorales artemiomorales force-pushed the reader/update-user-profile-dir-name branch from 595eea0 to 831a3ab Compare January 16, 2025 22:40
@artemiomorales artemiomorales merged commit f2c0eb1 into trunk Jan 17, 2025
13 checks passed
@artemiomorales artemiomorales deleted the reader/update-user-profile-dir-name branch January 17, 2025 16:16
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants