Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains Management Revamp: Center align Overview tab and fix form styles #98505

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

phcp
Copy link
Contributor

@phcp phcp commented Jan 16, 2025

Closes #97977

Proposed Changes

  • Center align Overview tab, increasing the max-width to 1400 to match the site overview size.
  • Add border radius to the Overview tab.
  • Fix form styles from Domain Forwarding and Glue Records expandable cards.
  • Fix styles of the loading placeholder for the overview tab.
  • The email tab was already center aligned, so no changes were applied.
Screenshot 2025-01-16 at 18 42 07 Screenshot 2025-01-16 at 18 41 57 Screenshot 2025-01-16 at 18 42 19

Why are these changes being made?

  • This is part of the Domain Management Revamp project: pfuQfP-13x-p2

Testing Instructions

  • Apply this PR to your local.
  • Go to http://calypso.localhost:3000/domains/manage?flags=calypso/all-domain-management.
  • Select a domain from the list.
  • You should see the Overview tab aligned in the center and with rounded borders.
  • Check if the placeholder also matches the container width and has rounded borders.
  • Expand the Domain Forwarding and Glue Records cards.
  • Check if the forms are rendered with consistent spacing and rounded borders.
  • Perform the same tests in the site context.
  • Perform regression tests in the previous layout.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@phcp phcp self-assigned this Jan 16, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@phcp phcp changed the title Domains Management Revamp: Center align overview tab and fix form styles Domains Management Revamp: Center align Overview tab and fix form styles Jan 16, 2025
@phcp phcp requested a review from a team January 16, 2025 22:06
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 16, 2025
@phcp phcp marked this pull request as ready for review January 16, 2025 22:06
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/domains-management-overview-styles on your sandbox.

Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it, and it looks nice. No regressions were found.

🚢

@phcp phcp merged commit d7fb6bd into trunk Jan 17, 2025
14 checks passed
@phcp phcp deleted the add/domains-management-overview-styles branch January 17, 2025 12:09
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main screens are not aligned properly
3 participants