Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: feature-detection lib #98602

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Cleanup: feature-detection lib #98602

merged 1 commit into from
Jan 20, 2025

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jan 20, 2025

Proposed Changes

Cleanup the unused lib/feature-detection.

Why are these changes being made?

That code is not in use since #94326.

Testing Instructions

Verify removed code is not in use.

@tyxla tyxla requested review from a team January 20, 2025 14:14
@tyxla tyxla self-assigned this Jan 20, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/lib-feature-detection on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@tyxla tyxla merged commit 8ebc622 into trunk Jan 20, 2025
17 of 18 checks passed
@tyxla tyxla deleted the remove/lib-feature-detection branch January 20, 2025 14:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants