Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain management: Update getEmailManagementPath logic to support checkout context #98620

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Jan 20, 2025

Related to #97474

Proposed Changes

  • Extend the generate path logic to support the use case when the feature flag is ON and the current route is under checkout.

Why are these changes being made?

  • Domain Management Revamp project

Testing Instructions

  • Feature flag: calypso/all-domain-management
  • Create a domain
  • Click on the Email tab
  • Purchase "Google Workspace"
  • On the "Congratulations on your purchase!" screen, click on the "Manage email" button
  • Check if you stay in the same context
Screenshot 2025-01-20 at 20 10 13

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii self-assigned this Jan 20, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/domains-management-email-19 on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~79 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +118 B  (+0.0%)      +43 B  (+0.0%)
entry-login                 +118 B  (+0.0%)      +43 B  (+0.0%)
entry-domains-landing       +118 B  (+0.0%)      +41 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~49 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
update-design-flow         +118 B  (+0.0%)      +33 B  (+0.0%)
link-in-bio-tld-flow       +118 B  (+0.0%)      +33 B  (+0.0%)
copy-site-flow             +118 B  (+0.0%)      +33 B  (+0.0%)
checkout                    +20 B  (+0.0%)      +16 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~116 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                    +118 B  (+0.0%)      +40 B  (+0.0%)
async-load-signup-steps-domains                                                        +118 B  (+0.0%)      +38 B  (+0.0%)
async-load-purchase-modal-wrapper                                                      +118 B  (+0.0%)      +40 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...       +118 B  (+0.0%)      +40 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                                             +118 B  (+0.0%)      +38 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@bogiii bogiii requested a review from a team January 20, 2025 19:17
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2025
@bogiii bogiii changed the title Domain management: Update generate path logic Domain management: Update getEmailManagementPath logic to support checkout context Jan 20, 2025
@bogiii bogiii marked this pull request as ready for review January 20, 2025 19:19
@bogiii bogiii requested a review from a team as a code owner January 20, 2025 19:19
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 👍

@bogiii bogiii merged commit 9159f8b into trunk Jan 21, 2025
19 checks passed
@bogiii bogiii deleted the update/domains-management-email-19 branch January 21, 2025 12:26
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants