Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains Management Revamp: Fix the last domain item in the left pane partially hidden #98628

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

phcp
Copy link
Contributor

@phcp phcp commented Jan 20, 2025

Closes #98610

Proposed Changes

  • Fix the last domain item in the left pane that was partially hidden.
Screenshot 2025-01-20 at 19 06 43
  • Fix missing translation.

Why are these changes being made?

  • This is part of the Domain Management Revamp project: pfuQfP-13x-p2

Testing Instructions

  • Apply this PR to your local.
  • Go to http://calypso.localhost:3000/domains/manage?flags=calypso/all-domain-management.
  • Select a domain in the list.
  • It should display the domain overview on the right side and the domain list on the left side.
  • Scroll down to the bottom of the domain list (left pane).
  • It should display the last item without cropping.
  • Go back to the full domains list.
  • Verify if the design looks consistent. No changes should apply to the full domains list.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@phcp phcp requested a review from a team January 20, 2025 22:17
@phcp phcp self-assigned this Jan 20, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~25 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
hosting        +67 B  (+0.0%)      +25 B  (+0.0%)
domains        +67 B  (+0.0%)      +25 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/domains-management-last-item-style on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the last domain item in the left pane getting partially hidden
2 participants