Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribers: Add via field to subscribers table, with sorting and filtering #99130

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

allilevine
Copy link
Member

@allilevine allilevine commented Jan 30, 2025

Related to https://github.com/Automattic/loop/issues/376

Proposed Changes

  • Change Subscription Type field to Type.
  • Add Via field with Email and Reader values.
Screen Shot 2025-01-30 at 3 54 14 PM
  • Add sorting and filtering on Via.
Type filter Via filter
Screen Shot 2025-01-30 at 3 52 09 PM Screen Shot 2025-01-30 at 3 51 41 PM

Why are these changes being made?

  • Requested feature: pe7F0s-2oe-p2#comment-3330

Testing Instructions

  • Go to /subscribers/{site URL} with a site that has both email and non-email subscribers (you can unsubscribe from emails in /read/subscriptions).
  • Check that there's a Via column that displays either "Email" or "Reader."
  • Sort by Via ascending and descending and check the results.
  • Filter by Via, Email and Reader and check the results.

Note that filtering by Type and Via simultaneously isn't currently possible. Follow-up: https://github.com/Automattic/loop/issues/391

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@allilevine allilevine self-assigned this Jan 30, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/via-column-to-subscriber-dataviews on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~25 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-subscriptions       +104 B  (+0.0%)      +25 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~140 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
subscribers       +538 B  (+0.0%)     +113 B  (+0.0%)
reader            +104 B  (+0.0%)      +27 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~29 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-subscribers       +104 B  (+0.1%)      +29 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@allilevine allilevine marked this pull request as ready for review January 30, 2025 20:56
@allilevine allilevine added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 30, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 30, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220077

Thank you @allilevine for including a screenshot in the description! This is really helpful for our translators.

@allilevine allilevine force-pushed the add/via-column-to-subscriber-dataviews branch from 4efb501 to 63899a5 Compare January 31, 2025 16:18
@allilevine allilevine requested a review from a team January 31, 2025 16:36
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
@dhanson-wp
Copy link

It would be helpful in these filtered views for the total count of Email subscribers and Followers to be displayed for each type. As a publisher, you would expect to see numbers for:

  • Total Subscribers
  • Email Subscribers
  • WPCOM Followers

@allilevine allilevine mentioned this pull request Jan 31, 2025
8 tasks
@allilevine
Copy link
Member Author

It would be helpful in these filtered views for the total count of Email subscribers and Followers to be displayed for each type. As a publisher, you would expect to see numbers for:

  • Total Subscribers
  • Email Subscribers
  • WPCOM Followers

@dhanson-wp Thanks for that feedback! I shared a video of what that could look like here: p1738348154220899/1738166831.661159-slack-C083ZPVVDTK

I would make this change in a follow-up PR since we're aligning on terminology, and would need to get translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants