-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribers: Add via field to subscribers table, with sorting and filtering #99130
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~25 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~140 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~29 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220077 Thank you @allilevine for including a screenshot in the description! This is really helpful for our translators. |
4efb501
to
63899a5
Compare
It would be helpful in these filtered views for the total count of Email subscribers and Followers to be displayed for each type. As a publisher, you would expect to see numbers for:
|
@dhanson-wp Thanks for that feedback! I shared a video of what that could look like here: p1738348154220899/1738166831.661159-slack-C083ZPVVDTK I would make this change in a follow-up PR since we're aligning on terminology, and would need to get translations. |
Related to https://github.com/Automattic/loop/issues/376
Proposed Changes
Why are these changes being made?
Testing Instructions
/subscribers/{site URL}
with a site that has both email and non-email subscribers (you can unsubscribe from emails in /read/subscriptions).Note that filtering by Type and Via simultaneously isn't currently possible. Follow-up: https://github.com/Automattic/loop/issues/391
Pre-merge Checklist