Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain-To-Plan Credit: Don't apply domain proration cost override to plans grid #99144

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

oswian
Copy link
Contributor

@oswian oswian commented Jan 31, 2025

Related to https://github.com/Automattic/martech/issues/3669

Proposed Changes

Requires: 170944-ghe-Automattic/wpcom

For users who have unused domain credit after purchasing a domain and no plan, we will be displaying a credit notice above the plans grid, however we do not want to display the discount in the plan grid itself.

Old New
CleanShot 2025-01-31 at 16 11 20@2x CleanShot 2025-01-31 at 16 12 18@2x

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@oswian oswian self-assigned this Jan 31, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~16 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +50 B  (+0.0%)      +16 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~201 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
theme                         +100 B  (+0.0%)      +29 B  (+0.0%)
stats                         +100 B  (+0.0%)      +30 B  (+0.0%)
site-purchases                +100 B  (+0.0%)      +27 B  (+0.0%)
site-overview                 +100 B  (+0.0%)      +22 B  (+0.0%)
purchases                     +100 B  (+0.0%)      +27 B  (+0.0%)
posts-custom                  +100 B  (+0.0%)      +24 B  (+0.0%)
posts                         +100 B  (+0.0%)      +24 B  (+0.0%)
plugins                       +100 B  (+0.0%)      +24 B  (+0.0%)
plans                         +100 B  (+0.0%)      +24 B  (+0.0%)
migrate                       +100 B  (+0.0%)      +23 B  (+0.0%)
jetpack-app                   +100 B  (+0.0%)      +24 B  (+0.0%)
hosting                       +100 B  (+0.0%)      +27 B  (+0.0%)
domains                       +100 B  (+0.0%)      +27 B  (+0.0%)
checkout                      +100 B  (+0.0%)      +18 B  (+0.0%)
update-design-flow             +50 B  (+0.0%)      +14 B  (+0.0%)
subscribers                    +50 B  (+0.0%)      +10 B  (+0.0%)
staging-site                   +50 B  (+0.0%)      +10 B  (+0.0%)
site-tools                     +50 B  (+0.0%)      +10 B  (+0.0%)
site-settings                  +50 B  (+0.0%)      +10 B  (+0.0%)
settings                       +50 B  (+0.0%)      +10 B  (+0.0%)
performance-profiler           +50 B  (+0.0%)      +14 B  (+0.0%)
link-in-bio-tld-flow           +50 B  (+0.0%)      +14 B  (+0.0%)
import-hosted-site-flow        +50 B  (+0.0%)      +14 B  (+0.0%)
home                           +50 B  (+0.0%)      +10 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~48 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected       +100 B  (+0.0%)      +24 B  (+0.0%)
async-load-signup-steps-plans                         +100 B  (+0.0%)      +24 B  (+0.0%)
async-load-design-blocks                              +100 B  (+0.0%)      +24 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/plans-grid-dont-show-domain-credit-discount on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants