Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: don't autoopen the Help Center in Support Sessions #99164

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Jan 31, 2025

Fixes: pdDR7T-205-p2#comment-2548
Fixes: #99073

Proposed Changes

  • This disables auto-opening the Help Center during Support Sessions.

Testing Instructions

@alshakero alshakero added the [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. label Jan 31, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~99 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +174 B  (+0.0%)      +98 B  (+0.0%)
entry-main          +174 B  (+0.0%)      +97 B  (+0.0%)
entry-login         +174 B  (+0.0%)      +97 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@alshakero alshakero added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/support-session-help-center on your sandbox.

Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@alshakero alshakero merged commit 4f6f262 into trunk Jan 31, 2025
15 of 16 checks passed
@alshakero alshakero deleted the fix/support-session-help-center branch January 31, 2025 15:22
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Center: appears pre-opened when SUing to a user session (happens for specific accounts)
3 participants