Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Memoize gated intervals selector #99171

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jan 31, 2025

Proposed Changes

Memoize the getGatedIntervals selector.

Note that #99170 takes care of the other similar warning that appears on this page.

Why are these changes being made?

The getGatedIntervals selector currently triggers a bunch of re-renders because it generates new objects on every run, and that's unnecessary since nothing really changes.

By memoizing the selector, we remove a bunch of unnecessary re-renders and fix this warning:

Screenshot 2025-01-31 at 17 39 04

Testing Instructions

  • Open /stats/day/:site where :site is a site on a high-tier plan.
  • Verify you no longer see the warning from the screenshot.

@tyxla tyxla added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. State [Type] Performance labels Jan 31, 2025
@tyxla tyxla requested review from a team January 31, 2025 15:45
@tyxla tyxla self-assigned this Jan 31, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~52 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +100 B  (+0.0%)      +52 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Copy link
Contributor

@Initsogar Initsogar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏽
Thanks for addressing these warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/ State [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants