-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Memoize gated intervals selector #99171
base: trunk
Are you sure you want to change the base?
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~52 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏽
Thanks for addressing these warnings.
Proposed Changes
Memoize the
getGatedIntervals
selector.Note that #99170 takes care of the other similar warning that appears on this page.
Why are these changes being made?
The
getGatedIntervals
selector currently triggers a bunch of re-renders because it generates new objects on every run, and that's unnecessary since nothing really changes.By memoizing the selector, we remove a bunch of unnecessary re-renders and fix this warning:
Testing Instructions
/stats/day/:site
where:site
is a site on a high-tier plan.