Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Onboarding: Remove wide screen flex style #99381

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Feb 5, 2025

Related to https://github.com/Automattic/loop/issues/319

Proposed Changes

  • Removes the Reader Onboarding panel's widescreen style because Reader Onboarding is constrained to the stream column max-width and, therefore, only goes "widescreen" on a very narrow range of browser widths.
  • To decrease the vertical space consumed by Reader Onboarding this PR floats the progress circle to the right of the header and reduces the margin between the header and steps.

Narrow style on desktop:

Before After
Screenshot 2025-02-05 at 5 24 28 PM Screenshot 2025-02-05 at 5 24 37 PM

Wide style (now narrow style in the after) on desktop:

Before After
Screenshot 2025-02-05 at 5 23 12 PM Screenshot 2025-02-05 at 5 23 28 PM

Mobile view:

Before After
Screenshot 2025-02-05 at 5 22 37 PM Screenshot 2025-02-05 at 5 22 21 PM

Why are these changes being made?

  • Improve UX by decreasing the amount of space taken up by Reader Onboarding.

Testing Instructions

  • The easiest way to test this is to create a new account on Calypso Live via /start/reader/user-social That should direct your to /reader
  • On /reader view Reader Onboarding in various widths and on mobile. Does it look good?

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Feb 5, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/reader-onboarding-style on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@DustyReagan DustyReagan marked this pull request as ready for review February 5, 2025 23:42
@DustyReagan DustyReagan requested a review from a team as a code owner February 5, 2025 23:42
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 5, 2025
@DustyReagan DustyReagan self-assigned this Feb 5, 2025
Copy link
Member

@mehmoodak mehmoodak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🚢

client/reader/onboarding/style.scss Outdated Show resolved Hide resolved
@DustyReagan DustyReagan merged commit a6246fe into trunk Feb 6, 2025
12 checks passed
@DustyReagan DustyReagan deleted the update/reader-onboarding-style branch February 6, 2025 16:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants