-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include query params in start-site-transfer redirect #99383
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~118 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
|
||
const queryParams = context.querystring ? `?${ context.querystring }` : ''; | ||
return page.redirect( | ||
`/sites/settings/site/${ context.params.site_id }/${ URL_MAP[ slug ] }${ queryParams }` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good!
Can we test this on Calypso Live? I tried updating the Authorize transfer
link in the email to a Calypso Live URL, but I encountered an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NVM if you’ve already figured out how to make it work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't even think to write that out, you need to catch the redirect and then go to the calypso live link manually. e.g.
If this redirects to /sites/settings/site/:site/transfer-site?site-transfer-confirm=the-confirm-code then it's working.
Related to #98875
Proposed Changes
Why are these changes being made?
Testing Instructions