Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include query params in start-site-transfer redirect #99383

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Feb 5, 2025

Related to #98875

Proposed Changes

  • Ensures query params are passed along with the transfer site redirect

Why are these changes being made?

  • Without the query param, users are unable to transfer sites, they land back on the first step of the transfer screen.

Testing Instructions

  • Transfer a site with the hold out treatment applied

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/transfer-site-redirect on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~118 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
settings-writing            +58 B  (+0.0%)      +19 B  (+0.0%)
settings-security           +58 B  (+0.0%)      +16 B  (+0.0%)
settings-reading            +58 B  (+0.0%)      +20 B  (+0.0%)
settings-podcast            +58 B  (+0.0%)      +19 B  (+0.0%)
settings-performance        +58 B  (+0.0%)      +15 B  (+0.0%)
settings-newsletter         +58 B  (+0.0%)      +19 B  (+0.0%)
settings-jetpack            +58 B  (+0.0%)      +23 B  (+0.0%)
settings-discussion         +58 B  (+0.0%)      +16 B  (+0.0%)
settings                    +58 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lsl lsl requested a review from okmttdhr February 5, 2025 23:42
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 5, 2025
@lsl lsl self-assigned this Feb 5, 2025
@lsl lsl merged commit b2c3c92 into trunk Feb 5, 2025
16 checks passed
@lsl lsl deleted the update/transfer-site-redirect branch February 5, 2025 23:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 5, 2025

const queryParams = context.querystring ? `?${ context.querystring }` : '';
return page.redirect(
`/sites/settings/site/${ context.params.site_id }/${ URL_MAP[ slug ] }${ queryParams }`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good!

Can we test this on Calypso Live? I tried updating the Authorize transfer link in the email to a Calypso Live URL, but I encountered an error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM if you’ve already figured out how to make it work :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't even think to write that out, you need to catch the redirect and then go to the calypso live link manually. e.g.

https://container-pedantic-noether.calypso.live/settings/start-site-transfer/test131134.wordpress.com?site-transfer-confirm=the-confirm-code

If this redirects to /sites/settings/site/:site/transfer-site?site-transfer-confirm=the-confirm-code then it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants