Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shell): parameter namespace is being ignored #161

Conversation

viniciusartur
Copy link
Contributor

This PR addresses the issue reported on #159 where the parameter namespace is being ignored when the Kubernetes context is set via kubectl config set-context.

Tested with:

❯ kubectl config set-context --current --namespace=test                                                                                                                                    
Context "default" modified.

❯ ./dist/cyphernetes shell 
...
(default) test » 

❯ ./dist/cyphernetes shell --namespace default
...
(default) default » 

❯ kubectl config set-context --current --namespace=default                                                                                                                                  
Context "default" modified.

❯ ./dist/cyphernetes shell 
...
(default) default » 

❯ ./dist/cyphernetes shell --namespace test
...
(default) test » 

❯ ./dist/cyphernetes shell -A 
...
(default) ALL NAMESPACES »

Copy link
Owner

@AvitalTamir AvitalTamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @viniciusartur this is great, I think this line was an early artifact from before we were using the default config loading rules.

Thanks for catching and fixing this!

@AvitalTamir AvitalTamir merged commit 8ac5240 into AvitalTamir:main Dec 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants