Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle non namespaced resources properly #168

Merged
merged 4 commits into from
Jan 3, 2025
Merged

fix: handle non namespaced resources properly #168

merged 4 commits into from
Jan 3, 2025

Conversation

naorpeled
Copy link
Collaborator

@naorpeled naorpeled commented Dec 30, 2024 •
edited
Loading

closes #149

TODO:

  • check if we can optimize and create a gvrCacheEntry struct that already contains the isNamespaced flag

@AvitalTamir AvitalTamir marked this pull request as ready for review January 3, 2025 06:53
@AvitalTamir
Copy link
Owner

@naorpeled works great! I added cache, going to merge and release.

@AvitalTamir AvitalTamir merged commit db8b7ad into main Jan 3, 2025
1 check passed
@AvitalTamir AvitalTamir deleted the fix/handle-non-namespaced-resources-properly branch January 3, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several macros installed by default are not working
2 participants
@naorpeled @AvitalTamir