Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export settings now retries when file access permissions are granted. #728

Closed
wants to merge 2 commits into from
Closed

Conversation

kahays
Copy link
Contributor

@kahays kahays commented Jun 18, 2021

Should fix #705? On my machine/test device running Android 10, I needed to change AndroidManifest.xml to get the fix to work reliably from a clean install, but didn't discover that until I had already pushed the other change 🤦‍♀️ sorry!

@kahays kahays changed the title Export settings will retry when file access permissions are granted. Export settings now retries when file access permissions are granted. Jun 18, 2021
@Sereri
Copy link
Member

Sereri commented Jul 4, 2021

Hey,
Sorry it took me so long. I currently really only have time for this on the weekend and the last two weekends...

Anyway, the change you sent would in theory fix the issue, yes. However as on Android version 30, the requestlegacyexternalstorage option will no longer work (see https://stackoverflow.com/questions/63364476/requestlegacyexternalstorage-is-not-working-in-android-11-api-30). We will have to use A30 as soon as November, so in around 4 months.

So while this is a solution for the very short run, this will not really help longer than that.

I've looked a bit into this and tried changing it to use getExternalFilesDir() instead but that basically dumps it into a folder most users won't be able to touch.
I guess the best would be to use the MediaStore and save it as MediaStore.Files maybe?

Can you try to refactor the code to use that?

@kahays
Copy link
Contributor Author

kahays commented Jul 4, 2021

Absolutely, I'll try to put that together in the next couple weeks. Thanks for looking into everything :)

@kahays kahays closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Settings doesn't if you haven't granted file access perms
2 participants