Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor nv plugins #744

Merged
merged 12 commits into from
Aug 27, 2024
Merged

Refactor nv plugins #744

merged 12 commits into from
Aug 27, 2024

Conversation

WenzDaniel
Copy link
Collaborator

What is the problem / what does the code in this PR do

Refactor NV/MV hitlets computation.

  1. Removes not needed parameters, to reduce required storage space.
  2. Adds a new simple summed waveform function. The function will only compute a biased representation of the summed waveform as the floating point part of the baseline is only partially added. The bias is ~0.5 % and does not play a crucial role when estimating the signal shape

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Coverage Status

coverage: 90.733% (-0.8%) from 91.546% when pulling ea99890 on refactor_nv_plugins into 9b508f7 on master.

@WenzDaniel WenzDaniel marked this pull request as ready for review August 1, 2023 11:36
@WenzDaniel WenzDaniel mentioned this pull request Aug 1, 2023
Merged
@WenzDaniel
Copy link
Collaborator Author

Long time no update making it a draft.

@WenzDaniel WenzDaniel marked this pull request as draft November 22, 2023 07:38
@WenzDaniel
Copy link
Collaborator Author

This PR goes together with: XENONnT/straxen#1228

@WenzDaniel WenzDaniel marked this pull request as ready for review August 27, 2024 12:15
dachengx
dachengx approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @WenzDaniel

@dachengx dachengx merged commit 6d96bb1 into master Aug 27, 2024
8 checks passed
@dachengx dachengx deleted the refactor_nv_plugins branch August 27, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dachengx dachengx dachengx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WenzDaniel @dachengx