Refactor and new feature of dailyclean.py #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script has been refactored with additional functions, making it more readable and easier to maintain. The `label_selector` for `stateful_set` has been modified. It now uses `axa.com/dailyclean!=false` to be consistent with the `deployment label_selector`. Added functionality to handle the metadata label `axa.com/dailyclean-start-replicas`. If this label is set on a deployment or stateful_set, its value will be utilized when the start script is executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and new feature of dailyclean.py
This PR introduces enhancements and refactors to improve script readability, maintainability, and a new functionality.
Changes:
label_selectorforstateful_sethas been modified. It now usesaxa.com/dailyclean!=falseto be consistent with thedeployment label_selector.axa.com/dailyclean-start-replicas. If this label is set on a deployment or stateful_set, its value will be utilized when the start script is executed.We have already tested this script.
Kindly review and provide feedback or modifications if required.
Thank you!