Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] force an exception if appium session is not opened #74

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

huaxing-yuan
Copy link
Collaborator

In the current release, when opening an Appium session (on Android or iOS) fails, but AndroidDriver or iOSDriver does not throw an exception, only an error message appears in the capabilities (e.g., browserstack).

In this scenario, the framework considers the session opened and continues the test.
In this release, we will check if the driver has a session ID and force an exception if it doesn't.

Copy link

sonarcloud bot commented Aug 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
67.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@huaxing-yuan huaxing-yuan merged commit f96aef3 into main Aug 30, 2024
5 of 6 checks passed
huaxing-yuan added a commit that referenced this pull request Sep 10, 2024
* [Mobile] force an exception if appium session is not opened (#74)

* Accessibility: update to axe core 4.9
* Accessibility: French verison of report
* add support of some language for accessibility test.
* update unit test for multi language.

* Optimise screenshot of accessibility test (from png to webp format)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant