Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced get_barset with get_bars, test for positions fixed #24

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

benrdavison
Copy link
Contributor

-get_barset no longer exists, replaced by get_bars (requires import of TimeFrame)
-In tests, it appears that trying to get Position is failing due to buying then immediately selling test stock; to make a position request, I believe the stock needs to be held, so I changed the purchase amount to 2 shares (I know this is not elegant, maybe someone will have a better idea, just wanted to bring awareness to why tests were failing).

Thanks!
BD

@AxelGard
Copy link
Owner

AxelGard commented Aug 3, 2022

Thank you!
Your changes looks good.

Yeah I need to rewrite the tests to actually be some proper mock tests, but they do catch things like this, so thanks!

@AxelGard
Copy link
Owner

AxelGard commented Aug 3, 2022

Btw how are you liking cira? Anything you think is missing? @benrdavison

@AxelGard AxelGard self-requested a review August 3, 2022 10:35
@AxelGard
Copy link
Owner

AxelGard commented Aug 3, 2022

The test seems to fail due to the set version of alpaca is older and therefore does not have the TimeFrame. I can merge and re-run the test when I have upgraded the alpaca version. But then I need to check what else will break if I do so. Might take some time. 😅

@benrdavison
Copy link
Contributor Author

Thanks! Yes, I started looking into trying to create a simpler wrapper for Alpaca, and stumbled upon this, really enjoying, thanks again.

@AxelGard
Copy link
Owner

AxelGard commented Aug 4, 2022

Glad to hear that you like it!

@AxelGard AxelGard self-assigned this Aug 4, 2022
@AxelGard AxelGard added the bug Something isn't working label Aug 4, 2022
@AxelGard AxelGard merged commit 972462c into AxelGard:develop Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants