fix(axstorage)! Return GString from get_path
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`crates/axstorage/src/flex.rs`: - Return `GString` instead of `CString` because the latter is unsound since the safety preconditions of `CString` are not satisfied. In particular there is no guarantee that the allocator that `CString` will use to free the memory is the same as the one used by `axstorage` to allocate the memory. Change-Id: I5f1844925917de23d4ae1f920c9b65045237f396
apljungquist
changed the title
GString from get_path
Because paths generally are not guaranteed to be UTF-8 on linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behavior was not sound because
CStringcould try to free thememory with a different allocator than
glibused to allocate it.crates/axstorage/src/flex.rs:ax_storage_get_storage_idis left untouched because thedocumentation does not state that it must be freed by the user.
GStringbecause, even thoughglibis already part ofthe public interface, the C API does not guarantee that the paths are
valid UTF-8 and paths on Linux are not generally guaranteed to be
valid UTF-8.