-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: https://github.com/AxisCommunications/go-dpop/issues/9 #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated Parse() in parse.go, added parse test
zg009
requested review from
SalladinBalwer,
EmmaAndersen and
a354dpa
as code owners
November 20, 2023 17:04
SalladinBalwer
suggested changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you delete the changes inherited from your other branch I think this is good to go. Great work!
SalladinBalwer
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Please include a summary of the change, a relevant motivation and context.
-Updated
utils.go - Added the StripQueryAndFragments function to remove them explicitly from an httpURL and return a string which is called in parse.go
parse_test.go - Added a test case using a URL with Query and Fragment
utils_test.go - Added test cases proving correctness of utility func
Issue ticket number and link
[Bug]:
htu
claim is not verified correctly #9Checklist before requesting a review
Blocking on previous pull due to incorrect branching and overwriting main (If it's an issue I can clone the base repository and force merge and rebuild the project, this was not raising flags in my ide)