Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: https://github.com/AxisCommunications/go-dpop/issues/9 #10

Closed
wants to merge 21 commits into from
Closed

fix: https://github.com/AxisCommunications/go-dpop/issues/9 #10

wants to merge 21 commits into from

Conversation

zg009
Copy link

@zg009 zg009 commented Nov 20, 2023

Describe your changes

Please include a summary of the change, a relevant motivation and context.
-Updated
utils.go - Added the StripQueryAndFragments function to remove them explicitly from an httpURL and return a string which is called in parse.go
parse_test.go - Added a test case using a URL with Query and Fragment
utils_test.go - Added test cases proving correctness of utility func

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • [?] I have made corresponding changes to the documentation

Blocking on previous pull due to incorrect branching and overwriting main (If it's an issue I can clone the base repository and force merge and rebuild the project, this was not raising flags in my ide)

utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@SalladinBalwer SalladinBalwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you delete the changes inherited from your other branch I think this is good to go. Great work!

parse.go Outdated Show resolved Hide resolved
@zg009 zg009 closed this by deleting the head repository Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants