Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to built-in gutter renderer to prevent exception #254

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

CodeDrivenMitch
Copy link
Member

The way the gutter icon was built/customized to provides a popover even if only one item was in there, turned out to cause a lot of trouble. This PR simplifies it back to the way JetBrains recommends it. Fixes #235.

The way the gutter icon was built/customized to provides a popover even if only one item was in there, turned out to cause a lot of trouble. This PR simplifies it back to the way JetBrains recommends it. Fixes #235.
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Qodana Community for JVM

31 new problems were found

Inspection name Severity Problems
Unresolved reference in KDoc 🔶 Warning 25
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9 🔶 Warning 6

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@CodeDrivenMitch CodeDrivenMitch merged commit 324f3d9 into master Oct 27, 2023
3 checks passed
@smcvb smcvb deleted the fix/235-popup-exception branch October 27, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception thrown upon popup
3 participants