Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jta exceptions #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Jta exceptions #31

wants to merge 2 commits into from

Conversation

azzazzel
Copy link

This should fix the issue in #30
Please review.

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

bert-laverman
bert-laverman approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@bert-laverman bert-laverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like what we discussed. SonarQube would like some units tests, but it wasn't too happy about this extension before this either.

abuijze
abuijze requested changes Jul 5, 2021
View reviewed changes
Copy link
Member

@abuijze abuijze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some Javadoc on the newly introduced exception.

cdi/src/main/java/org/axonframework/extensions/cdi/transaction/JtaTransactionException.java

import org.axonframework.common.AxonException;

public class JtaTransactionException extends AxonException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuijze abuijze abuijze requested changes

@bert-laverman bert-laverman bert-laverman approved these changes

Assignees

@azzazzel azzazzel

Labels
Priority 1: Must Status: In Progress Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azzazzel @CLAassistant @abuijze @bert-laverman @smcvb