chore: using debug() in builder when failure happens. #11205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasxia01
commented
Jan 14, 2025
| @@ -1314,8 +1314,7 @@ int main(int argc, char* argv[]) | |||
| { | |||
| try { | |||
| std::vector<std::string> args(argv + 1, argv + argc); | |||
| debug_logging = flag_present(args, "-d") || flag_present(args, "--debug_logging"); | |||
There was a problem hiding this comment.
deleted because it was not being used anywhere. Instead use NDEBUG env var.
lucasxia01
commented
Jan 14, 2025
| @@ -18,6 +18,7 @@ template <typename FF_> class CircuitBuilderBase { | |||
| using EmbeddedCurve = std::conditional_t<std::same_as<FF, bb::g1::coordinate_field>, curve::BN254, curve::Grumpkin>; | |||
|
|
|||
| size_t num_gates = 0; | |||
| bool has_dummy_witnesses; | |||
There was a problem hiding this comment.
add comment and set to false
lucasxia01
commented
Jan 14, 2025
| @@ -359,7 +359,7 @@ class UltraCircuitBuilder_ : public CircuitBuilderBase<typename ExecutionTrace_: | |||
| const std::vector<uint32_t>& public_inputs, | |||
| size_t varnum, | |||
| bool recursive = false) | |||
| : CircuitBuilderBase<FF>(size_hint) | |||
| : CircuitBuilderBase<FF>(size_hint, witness_values.empty()) | |||
There was a problem hiding this comment.
both mega and ultra circuit builders will call this, so it should account for all write_vk flows
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.