feat: proposer forwarder contract #11403

just-mitch · 2025-01-21T21:41:59Z

See the design.

TLDR:

make a forwarder contract that dispatches to the various things a sequencer does (publish a block, vote, claim a quote, etc)
refactor the L1 publisher into a classes dedicated for the prover node, and for the sequencer.

Future work:

yarn-project/sequencer-client/src/sequencer/sequencer.test.ts

yarn-project/end-to-end/src/e2e_p2p/upgrade_governance_proposer.test.ts

yarn-project/ethereum/src/deploy_l1_contracts.ts

Maddiaa0 · 2025-01-28T23:08:07Z

yarn-project/ethereum/src/deploy_l1_contracts.ts

@@ -190,7 +200,13 @@ export interface DeployL1ContractsArgs extends L1ContractsConfig {

 export type L1Clients = {
  publicClient: PublicClient<HttpTransport, Chain>;
-  walletClient: WalletClient<HttpTransport, Chain, Account>;
+  walletClient: Client<


curious as to why this had to change from the WalletClient type

It is to merge in the public actions with the wallet client.

yarn-project/ethereum/src/deploy_l1_contracts.ts

yarn-project/ethereum/src/contracts/rollup.ts

yarn-project/archiver/src/archiver/data_retrieval.ts

Maddiaa0 · 2025-01-28T23:47:35Z

yarn-project/archiver/src/archiver/data_retrieval.ts

+      });
+
+      if (rollupFunctionName === 'propose') {
+        rollupData = callData;


i feel like we can just return immediately here. and skip reducing the rollup calls

Maddiaa0 · 2025-01-28T23:48:32Z

yarn-project/aztec.js/src/utils/anvil_test_watcher.ts

@@ -60,6 +63,23 @@ export class AnvilTestWatcher {
    await this.filledRunningPromise?.stop();
  }

+  async mineIfOutdated() {


this must have been a pain

yarn-project/end-to-end/src/fixtures/utils.ts

yarn-project/end-to-end/src/e2e_epochs.test.ts

yarn-project/ethereum/src/contracts/rollup.ts

yarn-project/ethereum/src/l1_tx_utils.ts

Maddiaa0 · 2025-01-29T00:31:56Z

yarn-project/sequencer-client/src/client/sequencer-client.ts

+    const forwarderContract =
+      config.customForwarderContractAddress && config.customForwarderContractAddress !== EthAddress.ZERO
+        ? new ForwarderContract(publicClient, config.customForwarderContractAddress.toString())
+        : await ForwarderContract.create(walletClient.account.address, walletClient, publicClient, log);


when moving to live networks we should probably add a command to our CLI that does this initialisation, we dont want to have people accidentally keep deploying these over config errors

Good call. I filed 11603

Maddiaa0

minor comments, huge effort well done

spypsy · 2025-01-30T12:54:23Z

yarn-project/ethereum/src/l1_tx_utils.ts

+    };
+  }
+
+  public async tryGetErrorFromRevertedTx(


some of this is covered in formatViemError function.
It's a bit of a mess and I wanted to spend some time to get it actually right, wonder if it'd be worth me doing on top of this PR (as a separate one)

I saw that you wanted to merge this today so feel free to ignore, will work on it once merged

Yeah agreed. The formatViemError function came into being after I had done the initial refactoring, so as you mentioned, this is a semi-stale artifact.

Definitely it is worth investing in error handling after this PR goes in.

just-mitch · 2025-01-30T15:50:21Z

feat: proposer forwarder contract #11403 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

refactor: different publishers for sequencer and prover feat: sequencer publisher uses forwarder contract

just-mitch linked an issue Jan 21, 2025 that may be closed by this pull request

feat(sequencer,L1): proposer forwarder contract #11103

Open

just-mitch changed the title ~~11103 featsequencerl1 proposer forwarder contract~~ feat: proposer forwarder contract Jan 23, 2025

just-mitch marked this pull request as ready for review January 23, 2025 19:29

just-mitch force-pushed the 11103-featsequencerl1-proposer-forwarder-contract branch 6 times, most recently from c3f76cd to 339bc31 Compare January 27, 2025 20:41

just-mitch added the e2e-all CI: Enables this CI job. label Jan 27, 2025

just-mitch force-pushed the 11103-featsequencerl1-proposer-forwarder-contract branch 3 times, most recently from 23256d2 to f72faad Compare January 28, 2025 18:37