refactor: replace kv-store backend in pxe, key store and wallet #12087
+256
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexghr
force-pushed
the
ag/refactor-pxe-db
branch
from
f2d3ac8 to
2f9b570
Compare
alexghr
force-pushed
the
ag/refactor-pxe-db
branch
from
621a013 to
3791f62
Compare
alexghr
commented
Feb 19, 2025
Comment on lines
+26
to
+29
| auto code = call_lmdb_func_with_return(mdb_put, tx.underlying(), db.underlying(), &dbKey, &dbVal, flags); | ||
| if (code == MDB_KEYEXIST && duplicatesPermitted) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Pointing out this change since I encountered instances in this refactor where the same key/value entry was being added to a dupSort database.
This change makes the C++ module swallow the error making it behave more like the previous wrapper.
Thunkar
reviewed
Feb 19, 2025
alexghr
commented
Feb 19, 2025
|
|
||
| private static instance: WalletDB; | ||
|
|
||
| private aliasCache = new Map<string, string>(); |
There was a problem hiding this comment.
This cache is necessary because the parsers for custom Commander options need to by synchronous.
PhilWindle
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Looks ok to me but should probably ask @Thunkar to take a look.
Hah, looks like he already did! |
PhilWindle
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11658