Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding test CI workflow #29

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Conversation

wei3erHase
Copy link
Contributor

@wei3erHase wei3erHase commented Dec 27, 2024

addressing #17, the workflow downloads dependencies and executes yarn test

@wei3erHase wei3erHase changed the title test: adding test CI workflow (#1) test: adding test CI workflow Dec 27, 2024

- name: Set Aztec version and start sandbox
run: |
VERSION=0.68.0 aztec-up
Copy link
Collaborator

@critesjosh critesjosh Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
VERSION=0.68.0 aztec-up
VERSION=0.69.1 aztec-up

@wei3erHase wei3erHase requested a review from critesjosh January 14, 2025 19:36
Copy link
Collaborator

@critesjosh critesjosh Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you delete this file? then i think its good to go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not being added but modified, should we delete and add it to the .gitignore?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are right. ill merge and fix it

@critesjosh critesjosh merged commit 8653df0 into AztecProtocol:main Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants