Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a note to create a database before trying to create sql cache t… #617

Closed
wants to merge 1 commit into from

Conversation

aremo-ms
Copy link
Contributor

Addressing #597
Added a note to create a database prior to running SQL cache command

Copy link
Contributor

@kalyankrishna1 kalyankrishna1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the latest codegen, update sample.json , test and then present back forr eview

@kalyankrishna1
Copy link
Contributor

Look at and close this one too -> #136

@@ -148,13 +148,15 @@ Note: if you had used the automation to setup your application mentioned in [Ste
> },
> ```

1. If you do not have an existing database and tables needed for token caching, you can execute the `dotnet sql-cache create` command to create the table for you. To do that, follow the steps below.
1. If you do not have a tables needed for token caching, you can execute the `dotnet sql-cache create` command to create the table for you. To do that, follow the steps below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. If you do not have a tables needed for token caching, you can execute the `dotnet sql-cache create` command to create the table for you. To do that, follow the steps below.
1. If you do not have the tables needed for token caching, you can execute the `dotnet sql-cache create` command to create the table for you. To do that, follow the steps below.

Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aremo-ms aremo-ms closed this Dec 1, 2022
@aremo-ms aremo-ms deleted the aremo-ms/Issue597-addressed branch December 1, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants