-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azdevify azure-sql-db-session-recommender. #7
Conversation
update azure.yaml
infra/main.bicep
Outdated
keyVaultName: keyVault.outputs.name | ||
} | ||
} | ||
resource kv 'Microsoft.KeyVault/vaults@2023-02-01' existing = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this ref?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref key vault to get service keys. Next, we will use AUTH_TYPE
(RBAC or KEYS) to replace it.
Modify format and content Modify format and content
Modify function.bicep
@jongio - Updated based on all your comments, except for getting the keys for related services. Next, we will continue to modify and no longer use key vault to store keys. Instead, we will use |
Can you please add a 3rd parameter to main.bicep called "USE_KEY_VAULT"? Default it to Thanks |
Add USE_KEY_VAULT parameter
@jongio We have added the In the updated code, we cannot directly use the The reason about the following files are not directly used in the "infra/core" folder:
|
I just tested it and I got the following error:
|
@yorek According to the error message, the link you are using is the main branch. However, the file |
Just tested, it works just like magic! Impressive :) One thing I noticed, the first time I run After that, everything worked perfectly. I think I just fell in love with AZD :) Two requests:
Otherwise it is quite complex to connect and query the database :) |
Even better if you go set the Microsoft Entra admin for Azure SQL server to be the identity of who created/deployed the solution |
@yorek Yeah, need to run Additionally, we haved added code here to set the Microsoft Entra admin for Azure SQL server. Please re-review. |
Thanks a lot, it all works flawlessly! Thanks a lot for the contribution, merged now :) |
This pr is all changes to convert
azure-sql-db-session-recommender
application into an Azd template.You can currently deploy this application using azd by following the steps below:
azd init -t Menghua1/azure-sql-db-session-recommender -b azdevify
supportingScriptUris
parameter in theinfra\app\sqlserver.bicep
file tohttps://raw.githubusercontent.com/Menghua1/azure-sql-db-session-recommender/azdevify/database/setup-database.sh
.azd up
.Wait a moment for the resource deployment to complete, click the Website endpoint and you will see:
@jongio and @yorek for notification.