Use smaller base image, based on Alpine #33
Conversation
|
I don't see why this isn't being merged. It reduces the image size from 950 MB to 193 MB! |
|
@pelithne What do you mean by original repo? |
|
@neilpeterson @iainfoulds What is stopping you from merging this? |
|
@Overv I must have commented in my sleep :-), please disregard! |
|
@Overv I wasn't a repo admin, so didn't receive notifications on this PR. I'm not sure why the original manifest used the larger Ubuntu image. We can prioritize this against other deliverables and review in order to merge it. Please be respectful in how you ask for assistance or updates. |
|
@iainfoulds I asked this way because I just thought it was strange that such an simple and obvious improvement appeared to be overlooked. I was going through the tutorial for AKS last week and the first thing I wondered was why such a simple web app required me to push such a huge image. A tutorial ought to promote best practices. |
.github/workflows/main.yml
Outdated
There was a problem hiding this comment.
Is this file needed to support the base image change? or is it out of scope of this PR?
azure-vote-all-in-one-redis.yaml
Outdated
There was a problem hiding this comment.
many of these changes have been incorporated by other merged PRs. Please rebase.
azure-vote-all-in-one-redis.yaml
Outdated
| containers: | ||
| - name: azure-vote-front | ||
| image: microsoft/azure-vote-front:v1 | ||
| image: privatepelithne.azurecr.io/azuredocs/azure-vote-front:latest |
There was a problem hiding this comment.
This should stay a reference to the image in MCR which will appear after a rebase:
https://github.com/Azure-Samples/azure-voting-app-redis/blob/master/azure-vote-all-in-one-redis.yaml#L60
There was a problem hiding this comment.
Please leave the original values and revert this change.
workflow/main.yml
Outdated
There was a problem hiding this comment.
similar to .github/workflows, is this needed to support the proposed image change? or is this out of scope?
|
new update |
PR related to #32
The only change is that the base image is changed to a smaller, Alpine based, version. This make the whole app more light weight without changing any features.
The change has been manually tested to work with the current tutorial: https://docs.microsoft.com/en-us/azure/aks/tutorial-kubernetes-prepare-app
However, the
docker imagescommands used in the tutorial will render a slightly different output