Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various dev container improvements #109

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Various dev container improvements #109

merged 1 commit into from
Dec 19, 2023

Conversation

adamdougal
Copy link
Collaborator

@adamdougal adamdougal commented Dec 15, 2023 •
edited
Loading

Purpose

  • Install python dependencies after creation
    • This avoids the need for developers to install them manually
    • Aligned the version of streamlit between the base app and extensions to avoid a conflict
  • Install all recommended VSCode extensions
    • This avoids the need for developers to install them manually
  • Set default function path
    • This avoids a popup requesting this on startup
  • Set python interpreter path
    • This enabled VSCode to automatically detect installed dependencies

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
Open the project in the dev container

What to Check

Verify that the following are valid

  • all extensions are installed
  • python files open with no dependencies missing
  • no pop ups open

Other Information

Required by #69

@adamdougal
Various dev container improvements
dc684b3 
- Install python dependencies after creation
  - This avoids the need for developers to install them manually
  - Aligned the version of streamlit between the base app and extensions
    to avoid a conflict
- Install all recommended VSCode extensions
  - This avoids the need for developers to install them manually
- Set default function path
  - This avoids a popup requesting this on startup
- Set python interpreter path
  - This enabled VSCode to automatically detect installed dependencies
@ross-p-smith
Copy link
Collaborator

Relates to #69

@ross-p-smith ross-p-smith merged commit 3c475a8 into Azure-Samples:main Dec 19, 2023
1 check passed
@adamdougal adamdougal deleted the feature/dev-container-improvements branch December 19, 2023 11:44
eduardogch pushed a commit to devopsdale/chat-with-your-data-solution-accelerator that referenced this pull request Apr 30, 2024
@ross-p-smith
Merge pull request Azure-Samples#109 from adamdougal/feature/dev-cont…
3cdc493 
…ainer-improvements

Various dev container improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ross-p-smith ross-p-smith ross-p-smith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamdougal @ross-p-smith