Adding roles for logged in user for local development #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross-p-smith
approved these changes
Jan 18, 2024
docs/LOCAL_DEPLOYMENT.md
Outdated
| ``` | ||
| Then deploy the bicep file using the below command: | ||
| ```shell | ||
| az deployment group create --resource-group {your_resource_group} --template-file deployment.json --subscription {your_azure_subscription_id} |
There was a problem hiding this comment.
Suggested change
| az deployment group create --resource-group {your_resource_group} --template-file deployment.json --subscription {your_azure_subscription_id} | |
| az deployment group create --resource-group {your_resource_group} --template-file deployment.bicep --subscription {your_azure_subscription_id} |
ross-p-smith
approved these changes
Jan 18, 2024
eduardogch
pushed a commit
to devopsdale/chat-with-your-data-solution-accelerator
that referenced
this pull request
Apr 30, 2024
) * fix for rbac roles * adding principal id for local dev & in docs * code review comments * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Ross Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Based on the principal id, roles can be assigned to the logged in user for local development
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
Adds roles for logged in user with principal type 'User'
How to Test
What to Check
Verify that the following are valid
Other Information