Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for uploading jpg & png #286

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

komalg1
Copy link
Collaborator

@komalg1 komalg1 commented Feb 9, 2024

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@adamdougal
Copy link
Collaborator

Heya! Changes look good. How does the layout loading and chunking strategy handle the images? Have you tested this with multiple images? Thanks!

@komalg1
Copy link
Collaborator Author

komalg1 commented Feb 12, 2024

Heya! Changes look good. How does the layout loading and chunking strategy handle the images? Have you tested this with multiple images? Thanks!

Yes I tested with couple of images and it worked fine. Loading strategy as Layout uses the Layout model for Document Intelligence (Azure Form Recognizer) which can parse images (extracting text) and the Chunking strategy as Layout then chunks the text as it would for a PDF

@adamdougal adamdougal added this pull request to the merge queue Feb 12, 2024
Merged via the queue into Azure-Samples:main with commit f7dd41e Feb 12, 2024
3 checks passed
eduardogch pushed a commit to devopsdale/chat-with-your-data-solution-accelerator that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin website not allowing to upload images
2 participants