CWE-20 - Code Security #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report •
|
||||||||||||||||||||||||||||||
adamdougal
reviewed
Apr 9, 2024
ross-p-smith
force-pushed
the
ross/cwe-20
branch
from
65b0489
to
1ae244c
Compare
eduardogch
pushed a commit
to devopsdale/chat-with-your-data-solution-accelerator
that referenced
this pull request
Apr 30, 2024
* Refactor SourceDocument class to handle SAS tokens for blob storage URLs * Added tests to exercise the sas_placeholder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When checking for Blob Storage we should only check that the domain ends with blob storage domain rather than it just contains it based on Code Security CWE-20
How to Test
Tested by Unit Tests