Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch print statements to use logger #640

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Switch print statements to use logger #640

merged 2 commits into from
Apr 9, 2024

Conversation

adamdougal
Copy link
Collaborator

Required by #637

@adamdougal adamdougal mentioned this pull request Apr 9, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/helpers
   ConfigHelper.py633446%19–22, 30–31, 34, 39, 42, 45, 48, 54–58, 63, 68–69, 75–76, 78–80, 83–86, 88, 92–93, 99–100, 218
code/backend/batch/utilities/orchestrator
   OrchestratorBase.py321843%14–20, 23–25, 31, 40–42, 49–51, 61
code/backend/batch/utilities/parser
   OutputParserTool.py390100% 
code/backend/batch/utilities/tools
   ContentSafetyChecker.py412539%16, 18–19, 24, 30–32, 35–36, 42–43, 49–54, 57–59, 61, 65–67, 69
   QuestionAnswerTool.py341944%20–22, 25–26, 31, 34, 39, 42, 46–47, 49–50, 53–55, 64, 66, 73
TOTAL165795042% 

Tests Skipped Failures Errors Time
48 0 💤 0 ❌ 0 🔥 10.361s ⏱️

ross-p-smith
ross-p-smith approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@ross-p-smith ross-p-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this impact anything @cecheta is working on?

@adamdougal
Copy link
Collaborator Author

I don't think so. @cecheta can you confirm? Thanks!

@cecheta
Copy link
Collaborator

cecheta commented Apr 9, 2024

Will this impact anything @cecheta is working on?

I should be fine

@adamdougal adamdougal added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 3e71fe1 Apr 9, 2024
5 checks passed
@adamdougal adamdougal deleted the adam/637-use-logger branch April 9, 2024 16:16
eduardogch pushed a commit to devopsdale/chat-with-your-data-solution-accelerator that referenced this pull request Apr 30, 2024
@adamdougal
Switch print statements to use logger (Azure-Samples#640)
7f1a917 
* Switch print statements to use logger

Required by Azure-Samples#637

* Fix log format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ross-p-smith ross-p-smith ross-p-smith approved these changes

@cecheta cecheta cecheta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamdougal @cecheta @ross-p-smith