Ibrahimmalhas patch web push notification bug fixes #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added oneSignalRegistrationToken, since there was a missing key for the API body
adding fetch dependancy
adding missing fetch depenecy
fixing type error getOneSignalRegistrationInfo & setOneSignalRegistrationInfo instead of getOneSignalRegistrationToken & setOneSignalRegistrationToken
|
@microsoft-github-policy-service agree company="Microsoft" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The main branch code for web-notification has some errors when running the app. I just added the fixes for some typo error on the code.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Run the "Web-Push-notification-sample" normally
Changes involve fix:
What to Check
Verify that the following are valid
Other Information