Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove initReactRenderTracker and fix ReadMe #148

Closed
wants to merge 2 commits into from
Closed

Remove initReactRenderTracker and fix ReadMe #148

wants to merge 2 commits into from

Conversation

Leah-Xia-Microsoft
Copy link
Member

Purpose

  • ...

Pull Request Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Upstream sample reference

Links to PR(s) that made the original change in the upstream sample:

  • ...

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

emlynmac
emlynmac reviewed May 21, 2024
View reviewed changes
README.md
1. Set your adminUserId string in `Server/appsettings.json`
1. `npm run setup` from the root directory
1. `npm run start` from the root directory
2. Set your endpoint URL string in `Server/appsettings.json`
Copy link
Contributor

@emlynmac emlynmac May 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be left as 1.
Markdown will adjust the render accordingly, but now we don't need to re-order if the instructions change

@Leah-Xia-Microsoft Leah-Xia-Microsoft deleted the leahxia/remove-initreactrendertracker branch August 22, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlynmac emlynmac emlynmac approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner

@alcail alcail Awaiting requested review from alcail alcail is a code owner

Assignees

@emlynmac emlynmac

@vhuseinova-msft vhuseinova-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leah-Xia-Microsoft @emlynmac @vhuseinova-msft