Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify predeploy hook (fixes #79) #93

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: simplify predeploy hook (fixes #79) #93

merged 1 commit into from
Aug 6, 2024
+2 −2

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Aug 6, 2024

Purpose

Seems like env vars are now properly exported during AZD hooks, so this will fix longstanding issues with PS

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@sinedied sinedied requested a review from glaucia86 August 6, 2024 09:29
@sinedied sinedied self-assigned this Aug 6, 2024
@sinedied sinedied mentioned this pull request Aug 6, 2024
Closed
glaucia86
glaucia86 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glaucia86 glaucia86 merged commit 48b1be9 into main Aug 6, 2024
5 checks passed
@glaucia86 glaucia86 deleted the fix-ps branch August 6, 2024 16:24
@sinedied sinedied mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

Assignees

@sinedied sinedied

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinedied @glaucia86