Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from deprecated AzureRM powershell modules to Az modules #97

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jagilber
Copy link
Contributor

Purpose

migrate from deprecated AzureRM powershell modules to Az modules
update all instances of azurerm commandlet use
tested updates in New-ServiceFabricClusterCertificate.ps1
updated comments for New-AzKeyVault to also include -EnabledForTemplateDeployment

  • ...

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
New-ServiceFabricClusterCertificate.ps1

What to Check

Verify that the following are valid
that certificate is created and imported

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant